-
Notifications
You must be signed in to change notification settings - Fork 186
[WIP] Upgrades #150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[WIP] Upgrades #150
Conversation
Hi, Apologies for the delay—I’m currently serving my country’s mandatory military duty, so code reviews will be slower than usual. I’ll gradually review the code over the coming days. I can still check my email daily, so feel free to reach out if anything is urgent. Best regards, |
Of course! Most of my work on this is as a hobby project, so I'm not available all the time either. That being said, this PR has gotten very big and should be broken down into smaller more manageable pieces for review. In my most recent work, I've been less disciplined about keeping things non-experimental, so some commits are changing hard-coded defaults. Those experimental sections should not be merged. To move forward it would be best to prioritize a list of features added in this branch to separate into a standalone branch. Reviewing what I have done so far could help build that list. In the meantime here is a list of what I think some of the more important features added here are:
Let me know which of these you want to prioritize and I'll split them into separate PRs. Feel free to give any general reviews here. I do have one minimal open PR here: #160 |
Hi @Erotemic , did you manage to reproduce the results of the original YOLOv9 with this set of upgrades? |
I haven't tried, but I also didn't do anything to modify algorithm behavior or defaults. Just quality of life improvements. |
I'm working on improving the repo so it can be used seemlessly with arbitrary COCO manifests (currently using the kwcoco package, but that can be factored out).
I'm also making other changes / fixing issues / style as I go along. I'm attempting to keep the git commit messages clean so pieces of this can be broken off if they want to be merged upstream. But my end goal is to just make this usable as a command line tool that doesn't requires messing with config files and putting them in the right place.