Fix point filtering logic in load_valid_labels()
#157
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the filtering issue in the
load_valid_labels()
function, where element-wise filtering can disrupt the 2D structure of coordinate pairs (Issue #156).Currently:
This element-wise approach can cause inconsistent row structures. To fix this, we can adopt row-wise filtering:
This fix ensures that x-y coordinate pairs remain intact.
However, filtering out each point individually can still break bounding boxes that include coordinates outside
[0, 1]
. To address this more fundamentally, I propose clipping any out-of-range coordinates to[0, 1]
whenever at least one point of the bounding box lies within the frame. If all points are completely outside the frame, we ignore the bounding box as invalid. This approach preserves as much of the bounding box as possible.Visualization of filtered bounding boxes (representing heads):
Current filtering logic:

Fixed filtering logic:

I look forward to your feedback on this change. Thank you!