Skip to content

Conversation

@hiraljj05
Copy link

@hiraljj05 hiraljj05 commented Jul 31, 2025

Description

This pull request removes the duplicate close icon rendered inside the DialogContent of the Resume Template Modal. The close icon is already provided in the DialogHeader, so the redundant icon has been removed to improve the user interface.

Fixes #245

Type of Change

  • New feature (e.g., new page, component, or functionality)
  • Bug fix (non-breaking change that fixes an issue)
  • UI/UX improvement (design, layout, or styling updates)
  • Performance optimization (e.g., code splitting, caching)
  • Documentation update (README, contribution guidelines, etc.)
  • [ ] Other (please specify): ____________________

Changes Made

  • Removed the extra close icon inside DialogContent of the modal.
  • Verified that the modal still closes correctly using the header’s close button.

Dependencies

  • No new dependencies introduced.
  • No version or configuration changes made.

Add Screenshots

If your PR consist of any UI changes, please provide screenshots or video (if requried).

Checklist

  • My code follows the style guidelines of this project.
  • I have tested my changes across major browsers/devices
  • I have tested my changes in development mode (npm run dev)
  • I have written or updated related tests, if necessary
  • This is already assigned Issue to me, not an unassigned issue.

@vercel
Copy link

vercel bot commented Jul 31, 2025

@hiraljj05 is attempting to deploy a commit to the muneerali199's projects Team on Vercel.

A member of the Team first needs to authorize it.

@netlify
Copy link

netlify bot commented Jul 31, 2025

👷 Deploy request for docmagic-muneer pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit f6f4cde

@netlify
Copy link

netlify bot commented Jul 31, 2025

👷 Deploy request for docmagic1 pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit f6f4cde

@yashksaini-coder
Copy link
Collaborator

@hiraljj05 can you share some screenshots of the build, kindly.

@hiraljj05
Copy link
Author

Screenshot 2025-08-01 191728

I have removed the duplicate close icon of the Resume Template Modals.

Copy link
Collaborator

@yashksaini-coder yashksaini-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good @Muneerali199 please check and merge the PR.

@Muneerali199
Copy link
Owner

@hiraljj05 please resolve conflicts then i ll merge it

@hiraljj05
Copy link
Author

@Muneerali199 Please check, I have resolved the conflict

Copy link
Collaborator

@yashksaini-coder yashksaini-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conflict removed, please merge @Muneerali199

Copy link
Collaborator

@Saksham932007 Saksham932007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't approve

@hiraljj05
Copy link
Author

Don't approve

why

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Duplicate Close Icons on Resume Template Modal

4 participants