Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Deprecate ::atRuleArgs() #1191

Open
wants to merge 2 commits into
base: v8.x
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ This project adheres to [Semantic Versioning](https://semver.org/).

### Deprecated

- Deprecate `::atRuleArgs()` (#1191)
- Deprecate extending `OutputFormat` (#1131)
- Deprecate `OutputFormat::get()` and `::set()` (#1107)
- Deprecate support for `-webkit-calc` and `-moz-calc` (#1086)
Expand Down
2 changes: 2 additions & 0 deletions src/CSSList/AtRuleBlockList.php
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,8 @@ public function atRuleName()

/**
* @return string
*
* @deprecated since V8.8.0, will be removed in version 9.0.0. Use the specific getter instead.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This class doesn't have a specific getter for $arguments, so one will need to be added first.

*/
public function atRuleArgs()
{
Expand Down
2 changes: 2 additions & 0 deletions src/CSSList/KeyFrame.php
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,8 @@ public function atRuleName()

/**
* @return string|null
*
* @deprecated since V8.8.0, will be removed in version 9.0.0. Use the specific getter instead.
*/
public function atRuleArgs()
{
Expand Down
2 changes: 2 additions & 0 deletions src/Property/AtRule.php
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@ public function atRuleName();

/**
* @return string|null
*
* @deprecated since V8.8.0, will be removed in version 9.0.0. Use the specific getter(s) in the implementing class instead.
*/
public function atRuleArgs();
}
2 changes: 2 additions & 0 deletions src/Property/CSSNamespace.php
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,8 @@ public function atRuleName()

/**
* @return array<int, string>
*
* @deprecated since V8.8.0, will be removed in version 9.0.0. Use the specific getters instead.
*/
public function atRuleArgs()
{
Expand Down
2 changes: 2 additions & 0 deletions src/Property/Charset.php
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,8 @@ public function atRuleName()

/**
* @return string
*
* @deprecated since V8.8.0, will be removed in version 9.0.0. Use the specific getter instead.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't have a getter for the CSSString object property, only one that returns a native string. I wonder if we should first add a getter for the CSSString.

*/
public function atRuleArgs()
{
Expand Down
2 changes: 2 additions & 0 deletions src/Property/Import.php
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,8 @@ public function atRuleName()

/**
* @return array<int, URL|string>
*
* @deprecated since V8.8.0, will be removed in version 9.0.0. Use the specific getters instead.
*/
public function atRuleArgs()
{
Expand Down
2 changes: 2 additions & 0 deletions src/RuleSet/AtRuleSet.php
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,8 @@ public function atRuleName()

/**
* @return string
*
* @deprecated since V8.8.0, will be removed in version 9.0.0. Use the specific getter instead.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't have a specific getter for the $arguments property, so we should add one first.

*/
public function atRuleArgs()
{
Expand Down