[TASK] Use delegation for DeclarationBlock -> RuleSet
#1194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeQZ
added this to the 9.0.0: Drop support for PHP < 7.2 and clean up things milestone
JakeQZ
force-pushed
the
task/declarationblock-delegate-ruleset
branch
from
7800603 to
73956e9
Compare
oliverklee
reviewed
Mar 19, 2025
src/CSSList/CSSList.php
Outdated
| @@ -41,7 +41,7 @@ abstract class CSSList implements Renderable, Commentable | |||
| protected $comments = []; | |||
|
|
|||
| /** | |||
| * @var array<int<0, max>, RuleSet|CSSList|Import|Charset> | |||
| * @var array<int<0, max>, RuleSet|CSSList|DeclarationBlock|Import|Charset> | |||
There was a problem hiding this comment.
I propose we introduce an interface instead, e.g. something like CSSListItem. (We could do this as a pre-patch to keep PRs small.)
There was a problem hiding this comment.
Doing so would also make Stan happy :)
oliverklee
reviewed
Mar 19, 2025
JakeQZ
force-pushed
the
task/declarationblock-delegate-ruleset
branch
4 times, most recently
from
4d7831a to
c1c27a9
Compare
... rather than inheritance. This will allow `DeclarationBlock` to instead extend `CSSBlockList` in order to support [CSS nesting](https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_nesting). This is a slightly-breaking change, since now `CSSBlockList::getAllRuleSets()` will include the `RuleSet` property of the `DeclarationBlock` instead of the `DeclarationBlock` itself. Part of #1170.
JakeQZ
force-pushed
the
task/declarationblock-delegate-ruleset
branch
from
c1c27a9 to
3a278e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... rather than inheritance.
This will allow
DeclarationBlockto instead extendCSSBlockListin order to supportCSS nesting.
This is a slightly-breaking change, since now
CSSBlockList::getAllRuleSets()will include theRuleSetproperty of theDeclarationBlockinstead of theDeclarationBlockitself.Part of #1170.