[CLEANUP] Whitespace-agnostic HTML test comparison #855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeQZ
force-pushed
the
tests/whitespace-agnostic-html
branch
from
feee440 to
484339e
Compare
In tests for `AbstractHtmlProcessor`, ignore whitespace differences in the outer `<html>` element. This will help with #831. Also added test that the `<body>` content passed to `fromHtml()` is preserved and returned by `render()`.
JakeQZ
force-pushed
the
tests/whitespace-agnostic-html
branch
from
484339e to
46f765f
Compare
oliverklee
requested changes
Apr 1, 2020
Rename `normalizeHtml` to `normalizeHtmlElement` and add return type annotation.
oliverklee
approved these changes
Apr 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In tests for
AbstractHtmlProcessor, ignore whitespace differences in the outer<html>element.This will help with #831.
Also added test that the
<body>content passed tofromHtml()is preservedand returned by
render().