Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't run python tests for pull requests #17

Closed
paymog opened this issue Dec 12, 2018 · 5 comments
Closed

Don't run python tests for pull requests #17

paymog opened this issue Dec 12, 2018 · 5 comments
Labels
bug Something isn't working infrastructure Infrastructure related: CI, CD, production, hardware, postgres, redis, etc...

Comments

@paymog
Copy link
Contributor

paymog commented Dec 12, 2018

We're still learning how to use Travis CI but it looks like we can't run the python unit tests for pull requests from from forks: https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions

This is related to #3.

It seems that when a PR is made, Travis is run in two "modes": Pull Request and Branch. We still have to do more investigating to see how we can run the tests. I suspect there's a way to run tests against an pseudo-merged PR where the environment variables will be available but I'm not sure. Maybe we ought to ask stack overflow.
@paymog paymog added bug Something isn't working infrastructure Infrastructure related: CI, CD, production, hardware, postgres, redis, etc... labels Dec 12, 2018
@paymog
Copy link
Contributor Author

paymog commented Dec 12, 2018

I think the right solution is to not run the tests through docker but to install dependencies and run tests directly. We should also cache the pip install.

paymog added a commit that referenced this issue Dec 12, 2018
@paymog
Build and test backend without docker
796e336 
Build and test the backend without docker so that tests can be run
against pull requests from forks. Fixes #17
@paymog paymog mentioned this issue Dec 12, 2018
Merged
paymog added a commit that referenced this issue Dec 12, 2018
@paymog
Build and test backend without docker
21c8217 
Build and test the backend without docker so that tests can be run
against pull requests from forks. Fixes #17
@Peddle
Copy link
Contributor

Peddle commented Dec 12, 2018

What award do you think is fair for closing out this issue?

I'm thinking ~400 coins? WDYT?

paymog added a commit that referenced this issue Dec 12, 2018
@paymog
Build and test backend without docker
1346c2d 
Build and test the backend without docker so that tests can be run
against pull requests from forks. Fixes #17
paymog added a commit that referenced this issue Dec 12, 2018
@paymog
Build and test backend without docker
6e5889f 
Build and test the backend without docker so that tests can be run
against pull requests from forks. Fixes #17
paymog added a commit that referenced this issue Dec 12, 2018
@paymog
Build and test backend without docker
32b3366 
Build and test the backend without docker so that tests can be run
against pull requests from forks. Fixes #17
paymog added a commit that referenced this issue Dec 12, 2018
@paymog
Build and test backend without docker
59f6941 
Build and test the backend without docker so that tests can be run
against pull requests from forks. Fixes #17
paymog added a commit that referenced this issue Dec 12, 2018
@paymog
Build and test backend without docker
76c4a52 
Build and test the backend without docker so that tests can be run
against pull requests from forks. Fixes #17
paymog added a commit that referenced this issue Dec 12, 2018
@paymog
Build and test backend without docker
3e16c40 
Build and test the backend without docker so that tests can be run
against pull requests from forks. Fixes #17
paymog added a commit that referenced this issue Dec 12, 2018
@paymog
Build and test backend without docker
57b7b34 
Build and test the backend without docker so that tests can be run
against pull requests from forks. Fixes #17
paymog added a commit that referenced this issue Dec 12, 2018
@paymog
Build and test backend without docker
2b39df3 
Build and test the backend without docker so that tests can be run
against pull requests from forks. Fixes #17
paymog added a commit that referenced this issue Dec 12, 2018
@paymog
Build and test backend without docker
ac41004 
Build and test the backend without docker so that tests can be run
against pull requests from forks. Fixes #17
paymog added a commit that referenced this issue Dec 12, 2018
@paymog
Build and test backend without docker
a0c3014 
Build and test the backend without docker so that tests can be run
against pull requests from forks. Fixes #17
paymog added a commit that referenced this issue Dec 12, 2018
@paymog
Build and test backend without docker
b0018a9 
Build and test the backend without docker so that tests can be run
against pull requests from forks. Fixes #17
paymog added a commit that referenced this issue Dec 13, 2018
@paymog
Build and test backend without docker
d390588 
Build and test the backend without docker so that tests can be run
against pull requests from forks. Fixes #17
@paymog
Copy link
Contributor Author

paymog commented Dec 13, 2018

400 sounds good. I'm having a lot of trouble. Looks like solc 5.0 was released recently which causes things to break: ethereum/py-solc#61

Also, it seems that older versions of solc aren't available anymore.

@paymog
Copy link
Contributor Author

paymog commented Dec 13, 2018

ethereum/py-solc#44

@paymog
Copy link
Contributor Author

paymog commented Dec 13, 2018

ethereum/py-solc#65

paymog added a commit that referenced this issue Dec 13, 2018
@paymog
Build and test backend without docker
37397bd 
Build and test the backend without docker so that tests can be run
against pull requests from forks. Fixes #17
paymog added a commit that referenced this issue Dec 13, 2018
@paymog
Build and test backend without docker
374262d 
Build and test the backend without docker so that tests can be run
against pull requests from forks. Fixes #17
paymog added a commit that referenced this issue Dec 13, 2018
@paymog
Build and test backend without docker
813a3b4 
Build and test the backend without docker so that tests can be run
against pull requests from forks. Fixes #17
paymog added a commit that referenced this issue Dec 13, 2018
@paymog
Build and test backend without docker
0d7362d 
Build and test the backend without docker so that tests can be run
against pull requests from forks. Fixes #17
paymog added a commit that referenced this issue Dec 13, 2018
@paymog
Build and test backend without docker
dd7a264 
Build and test the backend without docker so that tests can be run
against pull requests from forks. Fixes #17
paymog added a commit that referenced this issue Dec 13, 2018
@paymog
Build and test backend without docker
6a03013 
Build and test the backend without docker so that tests can be run
against pull requests from forks. Fixes #17
Peddle pushed a commit that referenced this issue Dec 13, 2018
@paymog @Peddle
Build and test backend without docker (#18)
027e8d1 
Build and test the backend without docker so that tests can be run
against pull requests from forks. Fixes #17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working infrastructure Infrastructure related: CI, CD, production, hardware, postgres, redis, etc...
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@paymog @Peddle