Build and test backend without docker #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wonder if we should investigate a docker solution in the future to help insure our prod and test environments stay as similar as possible. I'm LGTMing this though because we need to move fast, this will satisfice for now, and we can investigate the other solution in the future |
Peddle
previously approved these changes
Dec 12, 2018
paymog
force-pushed
the
build.python
branch
17 times, most recently
from
0d7362d to
dd7a264
Compare
Build and test the backend without docker so that tests can be run against pull requests from forks. Fixes #17
Peddle
approved these changes
Dec 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build and test the backend without docker so that tests can be run
against pull requests from forks. Fixes #17