Port audioplayer delegate to use gui media service #114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krisgesling
approved these changes
Mar 2, 2022
| T.Slider { | ||
| id: seekableslider | ||
| to: player.duration | ||
| //to: root.playerDuration |
There was a problem hiding this comment.
This seems to be handled up on L106-107 is that right? Can we delete this now?
| value: root.playerPosition | ||
|
|
||
| handle: Item { | ||
| x: seekableslider.visualPosition * (parent.width - (Kirigami.Units.largeSpacing + Kirigami.Units.smallSpacing)) |
There was a problem hiding this comment.
I've been playing with this a little as I've been seeing the positionMarker move slightly beyond the end of the seek bar at the end of tracks.
This seems to work for me:
x: seekableslider.visualPosition / (parent.width + {implicitWidth_of_hand}) * parent.width ** 2
maybe easier to reason as:
(visualPosition * parent.width) / (parent.width + hand.width) * parent.width
Does that make sense?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.