Skip to content

Conversation

@zcy1024
Copy link
Contributor

@zcy1024 zcy1024 commented Nov 3, 2025

Description

  • assert!(sui::types::is_one_time_witness(&otw)); without error code, so add EIsNotOTW.
  • ExtraField is used => remove #[allow(unused_field)]

Test plan

How did you test the new or updated feature?


Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • Protocol:
  • Nodes (Validators and Full nodes):
  • gRPC:
  • JSON-RPC:
  • GraphQL:
  • CLI:
  • Rust SDK:

@vercel
Copy link

vercel bot commented Nov 3, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
sui-docs Ready Ready Preview Comment Nov 4, 2025 11:46am
2 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
multisig-toolkit Ignored Ignored Preview Nov 4, 2025 11:46am
sui-kiosk Ignored Ignored Preview Nov 4, 2025 11:46am

@damirka
Copy link
Contributor

damirka commented Nov 4, 2025

Hey @zcy1024, thank you for your contribution! However, do you mind if I do it as a part of #24077 to ease the burden on generating snapshots? Also, maybe you could keep the changes and retarget them at the ds/cr-nits instead? All, except for snapshots, of course.

@damirka damirka self-assigned this Nov 4, 2025
@zcy1024
Copy link
Contributor Author

zcy1024 commented Nov 4, 2025

Only keep the changes to coin_registry.move and retarget to ds/cr-nits: #24173

I'm not sure if my understanding is correct.

@damirka
Copy link
Contributor

damirka commented Nov 4, 2025

That's right @zcy1024. So the issue with any external contributions to the framework is the race condition. Snapshots take time and must be regenerated each time, sometimes multiple times if someone has merged a change while snapshots were generating and being checked in CIs.

So the best (and the only efficient) strategy is to target someone's branch. For this change it's not needed, as I went ahead and included your changes in #24077 which should go in sometime this week or early next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants