Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
hayes-mysten
had a problem deploying
to
sui-typescript-aws-kms-test-env
GitHub Actions
Failure
Contributor
|
|
hayes-mysten
commented
Apr 17, 2025
| showBcs: true, | ||
| }, | ||
| }); | ||
| getObjects = this.root.middleware.wrap( |
Contributor
Author
There was a problem hiding this comment.
I don't love making all of these instance properties... We could also do
getObjects(options) {
return this.root.middleware.run('core', 'getObjects', this, [options], (options) => {
// contents
})
}
Collaborator
There was a problem hiding this comment.
Yeah neither do I, I'd probably do it this way
hayes-mysten
commented
Apr 17, 2025
| run<Args extends unknown[], Return extends unknown>( | ||
| scope: string, | ||
| name: string, | ||
| fn: (...args: Args) => Promise<Return>, |
Contributor
Author
There was a problem hiding this comment.
this should be the last arg
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes or additions included in this PR.
Test plan
How did you test the new or updated feature?