-
Notifications
You must be signed in to change notification settings - Fork 86
[dapp-kit-next]: expose ::part(trigger) for connect button styling #888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
71e7fc1
feat(dapp-kit): expose ::part(trigger) on connect button for CSS cust…
williamrobertson13 2853696
Add ::part(trigger) demo to React example app
williamrobertson13 d5a40de
work
williamrobertson13 b47c57d
work
williamrobertson13 19b06de
F
williamrobertson13 67d7ae5
F
williamrobertson13 6aa99bf
work
williamrobertson13 bbefb84
Merge branch 'main' into williamrobertson13/connect-btn-part
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@mysten/dapp-kit-core': minor | ||
| --- | ||
|
|
||
| Expose a styleable "trigger" part for more custom styling needs on the connect button |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -19,7 +19,10 @@ | |
| "packageManager": "[email protected]", | ||
| "pnpm": { | ||
| "overrides": { | ||
| "axios": "^1.13.5" | ||
| "axios": "^1.13.5", | ||
| "markdown-it@>=13.0.0 <14.1.1": ">=14.1.1", | ||
| "hono@<4.11.10": ">=4.11.10", | ||
| "minimatch@<10.2.1": ">=10.2.1" | ||
| } | ||
| }, | ||
| "engines": { | ||
|
|
||
10 changes: 3 additions & 7 deletions
10
packages/dapp-kit-next/packages/dapp-kit-core/.storybook/main.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,18 +1,14 @@ | ||
| import type { StorybookConfig } from '@storybook/web-components-vite'; | ||
|
|
||
| import { join, dirname } from 'path'; | ||
| import { dirname } from 'path'; | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Storybook was broken |
||
| import { fileURLToPath } from 'url'; | ||
|
|
||
| /** | ||
| * This function is used to resolve the absolute path of a package. | ||
| * It is needed in projects that use Yarn PnP or are set up within a monorepo. | ||
| */ | ||
| function getAbsolutePath(value: string): any { | ||
| return dirname(require.resolve(join(value, 'package.json'))); | ||
| return dirname(fileURLToPath(import.meta.resolve(value + '/package.json'))); | ||
| } | ||
|
|
||
| const config: StorybookConfig = { | ||
| stories: ['../src/**/*.mdx', '../src/**/*.stories.@(js|jsx|mjs|ts|tsx)'], | ||
| addons: [getAbsolutePath('@storybook/addon-essentials')], | ||
| framework: { | ||
| name: getAbsolutePath('@storybook/web-components-vite'), | ||
| options: {}, | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
audit CI was failing