Remove WebSocket client and streaming APIs from JSON-RPC transport#965
Merged
hayes-mysten merged 3 commits intomainfrom Mar 24, 2026
Merged
Remove WebSocket client and streaming APIs from JSON-RPC transport#965hayes-mysten merged 3 commits intomainfrom
hayes-mysten merged 3 commits intomainfrom
Conversation
Remove the WebSocket-based subscription system from the JSON-RPC client, including rpc-websocket-client.ts, the subscribe method on JsonRpcHTTPTransport, and related types (JsonRpcTransportSubscribeOptions, Unsubscribe, WebsocketClientOptions). Also removes ws/\@types/ws dev deps. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
hayes-mysten
had a problem deploying
to
sui-typescript-aws-kms-test-env
GitHub Actions
Failure
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
hayes-mysten
had a problem deploying
to
sui-typescript-aws-kms-test-env
GitHub Actions
Failure
Jordan-Mysten
approved these changes
Mar 24, 2026
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| '@mysten/sui': minor | |||
Collaborator
There was a problem hiding this comment.
We're just doing this because this has never worked right?
Contributor
Author
There was a problem hiding this comment.
we removed all the methods in 2.0, I think everything we are removing is either internal only, or removing options that won't cause issues if you continue to pass them
Contributor
Author
There was a problem hiding this comment.
I guess there are some types that may have been re-exported, but unlikely they are being used
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
hayes-mysten
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove the WebSocket-based subscription system from the JSON-RPC client. This removes:
rpc-websocket-client.ts(theWebsocketClientclass)subscribemethod fromJsonRpcHTTPTransportandJsonRpcTransportinterfaceWebSocketConstructorandwebsocketoptions fromJsonRpcHTTPTransportOptionsJsonRpcTransportSubscribeOptionsexported typeUnsubscribetype fromjsonRpc/types/common.tswsand@types/wsdev dependenciesTest plan
http-transport.test.ts, kept HTTP request testsWebSocketConstructorfrom test client constructionAI Assistance Notice