Simplified "deep copy" constructors needed for the IMF pointer.#198
Merged
Simplified "deep copy" constructors needed for the IMF pointer.#198
Conversation
Member
Author
|
Checked this change on GM1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Fdbk and Stfm classes have a lot of attributes for feedback and star formation, and they need to do a "deep copy" because of the IMF pointer. It is too easy to forget to add a new parameter to the copy constructor resulting in uninitialized attributes in the class. This was the root cause of a weird star formation history after a recent merge of star formation code with a downstream branch.
This is a rewrite so that the default constructor is used for the attributes, and only the IMF pointer gets the special constructor.
Note that the "pup" operators have a similar problem. We should also think about rewriting those.