Conversation
Owner
|
Hey @Jonghakseo thanks for taking a look at this, sorry for being so slow to reply to this. Just wondering if you've tested whether this also works in Firefox? Hopefully I have more time soon I can do a more thorough test! |
Author
|
I added support for firefox. Added for different support for mv3 itself, which requires a small modification to the manifest after the build. I've tested it myself, please check it out! And please take a look at the other PRs related to broken UI. |
Jonghakseo
commented
Oct 2, 2024
| "$schema": "https://json.schemastore.org/chrome-manifest", | ||
| "manifest_version": 3, | ||
| "name": "GIFs for GitHub", | ||
| "version": "1.2.11", |
Author
There was a problem hiding this comment.
This probably needs to be bumped up... Please be careful when deploying.
Author
There was a problem hiding this comment.
Merged
Owner
|
Thank you! Have included this in #83 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migaration to manifest version 3
https://developer.chrome.com/docs/extensions/develop/migrate/manifest
@N1ck