Skip to content

Added argument to gff3_to_fasta that allows user to determine what at… - #147

Merged
ChrisChilders-USDA merged 2 commits into
masterfrom
new-gff2fasta-option
Jun 1, 2026
Merged

Added argument to gff3_to_fasta that allows user to determine what at…#147
ChrisChilders-USDA merged 2 commits into
masterfrom
new-gff2fasta-option

Conversation

@MonicaPoelchau-USDA

Copy link
Copy Markdown
Contributor

…tributes are included in the fasta defline. Model used: GPT-5.4 mini

…tributes are included in the fasta defline. Model used: GPT-5.4 mini

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends gff3_to_fasta to let users control which GFF3 attributes are included in FASTA deflines via a new CLI argument, and updates docs/tests accordingly.

Changes:

  • Added -da/--defline_attributes and plumbing through script_main()main()extract_start_end()/splicer().
  • Implemented helpers to normalize attribute lists and format selected attributes into FASTA deflines, including a -d custom mode.
  • Updated unit tests and CLI documentation to cover the new behavior.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File Description
gff3tool/bin/gff3_to_fasta.py Adds defline_attributes support, formatting helpers, CLI flag, and wiring through extraction/splicing paths.
tests/unit/test_gff3_to_fasta_cli.py Updates call expectations for new parameter and adds a test for -d custom attribute-based deflines.
docs/gff3_to_fasta.md Documents the new -da option and the custom defline mode.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread docs/gff3_to_fasta.md Outdated
@codecov

codecov Bot commented Jun 1, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 71.08434% with 24 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.24%. Comparing base (e2e6bbd) to head (ea8ff0b).

Files with missing lines Patch % Lines
gff3tool/bin/gff3_to_fasta.py 71.08% 24 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #147      +/-   ##
==========================================
+ Coverage   54.86%   56.24%   +1.38%     
==========================================
  Files          28       28              
  Lines        5313     5378      +65     
==========================================
+ Hits         2915     3025     +110     
+ Misses       2398     2353      -45     
Files with missing lines Coverage Δ
gff3tool/bin/gff3_to_fasta.py 56.00% <71.08%> (+12.58%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2e6bbd...ea8ff0b. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 3 changed files in this pull request and generated no new comments.

@ChrisChilders-USDA ChrisChilders-USDA left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks ok to me

@ChrisChilders-USDA
ChrisChilders-USDA merged commit 68ec198 into master Jun 1, 2026
23 checks passed
@ChrisChilders-USDA
ChrisChilders-USDA deleted the new-gff2fasta-option branch June 1, 2026 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants