Fix gff3_merge crash on non-numeric root IDs - #148
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #148 +/- ##
==========================================
+ Coverage 56.24% 56.28% +0.04%
==========================================
Files 28 28
Lines 5378 5383 +5
==========================================
+ Hits 3025 3030 +5
Misses 2353 2353
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR prevents gff3_merge from crashing when root feature IDs don’t contain a numeric suffix by making Groups.name2id() derive idprefix more defensively.
Changes:
- Avoids assuming
roots[0]['attributes']['ID']matches(.+?)(\d+)by scanning roots until a numeric-suffix ID is found. - Initializes
idprefixsafely when no numeric-suffix root IDs exist.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ChrisChilders-USDA
left a comment
There was a problem hiding this comment.
I think that this should work.
No description provided.