Conversation
jppan-jpl
commented
Apr 21, 2026
jppan-jpl
commented
- Addressed bugs re: flag handling in test app
- Removed bitstring from python client
- refactored to use bitshift logic or struct bytearray extend in both the python client and test app
- cleaned up default test app properties file
- hit at least one of the python files with the formatter stick (sorry!)
… output. fixing bugs in KmcSdlsClient.py related to hex output. Modifying default managed parameters for aos/tm in kmc_sdls_test_app.properties.
…rwise exit 0. changed aos to not check IV, was getting errors with local db (unsure if it's a bug)
| cryptolib.aos.create_ecf=true | ||
| cryptolib.aos.check_fecf=false | ||
| cryptolib.aos.ignore_antireplay=false | ||
| cryptolib.aos.ignore_antireplay=true |
There was a problem hiding this comment.
i'm not sure if this is necessary; i was getting incrementing IV errors in my testing, could be an SADB problem.
There was a problem hiding this comment.
most changes here are formatting, sorry!
modified the Frame/TC/TM/AOS classes to use bitshift packing instead of the brittle bit "string" and hex mishmash. changes were tested before/after to ensure correctness.
also modified this app to only return an error code (non-zero exit) if an error occurs.
There was a problem hiding this comment.
changed all default frame lengths to 128 bytes, added a few more configs for TM/AOS.
There was a problem hiding this comment.
removed bitstring dependency, and refactored to bitshift and struct for header hex conversions. tested with before/after outputs.
| @@ -1,3 +1,2 @@ | |||
| cffi==1.14.6 | |||
| invoke==1.6.0 | |||
| bitstring==4.3.1 No newline at end of file | |||
There was a problem hiding this comment.
removed bitstring from requirements
|
1 participant
