Substituted grunt-zip for grunt-contrib-compress #901
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Substituted development dependency
grunt-zip
forgrunt-contrib-compress
.The latter is more actively maintained, has more robust binary data handling and better cross-platform compatibility.
https://github.com/twolfson/grunt-zip
https://github.com/gruntjs/grunt-contrib-compress
Note that
grunt-contrib-compress
uses a different library for compressing (archiver
) compared togrunt-zip
, which usesjszip
, which in its turn is also used as one of the few external dependencies within the engine itself. A review ofjszip
's functionality within Web WorldWind is in order to consider its substitution.Why Should This Be In Core?
At some point,
grunt-zip
began producing a corrupt bundle release artifact. See #900Benefits
Artifact .zip bundling now works OK.
Potential Drawbacks
None found.
Applicable Issues
Fixes #900