Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to v3 of actions/upload-pages-artifact #179

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

mnlevy1981
Copy link
Collaborator

@mnlevy1981 mnlevy1981 commented Jan 31, 2025

Description of changes:

Fixes #178 (I hope)
Our Build and Deploy workflow was using actions/upload-pages-artifact@v2, which was failing with a link to this deprecation notice. This PR updates to actions/upload-pages-artifact@v3, and I'm cautiously optimistic that the existing with: and path: are still part of the API for the updated version. I don't know if there's a way to test the workflow ahead of time, or if we just merge this in and hope the failing action starts to pass...

  • Have you followed the guidelines in our Contributor's Guide?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you made sure that the pre-commit checks passed (#8 in Adding Notebooks Guide)?
  • Have you hidden the code cells (#8 in Adding Notebooks Guide) in your notebook?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully tested your changes locally?
  • Have you moved any observational data that you are using to /glade/campaign/cesm/development/cross-wg/diagnostic_framework/CUPiD_obs_data and ensured that it follows this format within that directory: COMPONENT/analysis_datasets/RESOLUTION/PROCESSED_FIELD_TYPE?

Copy link
Collaborator

@TeaganKing TeaganKing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm also not sure of a way to test locally, but this seems like a reasonable solution. Do you want to update to v4 though? The deprecation notice seems to suggest using that version.

@mnlevy1981
Copy link
Collaborator Author

Do you want to update to v4 though? The deprecation notice seems to suggest using that version

I think actions/upload-artifact is up to v4, but we are using actions/upload-pages-artifact which wraps upload-artifact. The latest version of upload-pages-artifact is v3.0.1, but it does use upload-artifact@v4

@mnlevy1981 mnlevy1981 merged commit 9d4e96d into NCAR:main Jan 31, 2025
2 checks passed
@mnlevy1981 mnlevy1981 deleted the update_deploy_CI branch January 31, 2025 21:53
@mnlevy1981 mnlevy1981 mentioned this pull request Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing CI test
2 participants