Remove duplicated list of observation converters#1067
Open
hkershaw-brown wants to merge 2 commits intomainfrom
Open
Remove duplicated list of observation converters#1067hkershaw-brown wants to merge 2 commits intomainfrom
hkershaw-brown wants to merge 2 commits intomainfrom
Conversation
typo fixes anchors for links
8fc6148 to
c90a895
Compare
mjs2369
reviewed
Mar 12, 2026
Contributor
mjs2369
left a comment
There was a problem hiding this comment.
All the readmes for the obs converters are all in the observations/obs_converters/name_of_converter directory.
EX: observations/obs_converters/BATS/readme.rst
But the CHAMP obs converter readme is in the work dir: observations/obs_converters/CHAMP/work/README.rst
mjs2369
reviewed
Mar 12, 2026
| for and which will eventually be added to this directory. In the | ||
| meantime, if you have converters for data or interest in something that | ||
| is not in the repository, please `email the DART | ||
| group <mailto:dart@ucar.edu>`__. |
Contributor
There was a problem hiding this comment.
I think that these links to email the DART group should instead just list the dart email.
EX: "... is not in the repository, please email the DART
group at dart@ucar.edu"
These links open the mail app, which not everyone uses as many just use the browser.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This pull request
Fixes issue
Fixes #998
Types of changes
Documentation changes needed?
Tests
Please describe any tests you ran to verify your changes.
Built documentation locally, checked for broken links in the converter rsts. (Note there are a lot of broken links in dart because of the ../../../.html all over the code #849)
Checklist for merging
Checklist for release
Testing Datasets