Skip to content

Lonely programs that are not routinely built with existing quickbuild.shs get a quickdbuild.sh#1070

Open
hkershaw-brown wants to merge 5 commits intomainfrom
lonely-progs
Open

Lonely programs that are not routinely built with existing quickbuild.shs get a quickdbuild.sh#1070
hkershaw-brown wants to merge 5 commits intomainfrom
lonely-progs

Conversation

@hkershaw-brown
Copy link
Member

Description:

There are several (~31) programs that are not routinely built with existing quickbuild.sh so are not built with run_all_quickbuilds. This pull request adds two developer_test directories:

  • developer_tests/lonely_quickbuilds (maybe needs a better name)
    quickbuild.sh builds the programs not caught by dart quickbuild.shs
  • developer_tests/system_simulation
    quickdbuild.sh builds the programs in assimilation_code/programs/system_simulation
    Using the dev_test in quickdbuild.sh because the system simulation codes do not follow the layout of other dart programs.
    In addition, I do not think they actually need much of dart (only random sequences). Unclear if they should be using types_mod. So build could be simplified further (no preprocess), but this pull request just uses the bog standard dart build, preprocess + build.

Fixes issue

fixes #1068
Two of the system_similation programs did not compile because they had _r8 but are not using types_mod, these have been changed to .d0

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Documentation changes needed?

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.

Tests

Please describe any tests you ran to verify your changes.
run_all_quickdbuild.sh
https://github.com/NCAR/DART/actions/runs/22865933793

Checklist for merging

  • Updated changelog entry
  • Documentation updated
  • Update conf.py

Checklist for release

  • Merge into main
  • Create release from the main branch with appropriate tag
  • Delete feature-branch

Testing Datasets

  • Dataset needed for testing available upon request
  • Dataset download instructions included
  • No dataset needed

….shs

partial fix for #1068. This is the programs not in the system_simulation
directory
The quickbuild.sh is in developer tests. This is because
the system similution codes do not follow the layout of other dart programs.
In addition, I do not think they actually need much of dart (only random
sequences). Unclear if they should be using types_mod. So build could be
simplified further (no preprocess)

see #1068
@hkershaw-brown hkershaw-brown added the back burner very low priority. Future work? label Mar 9, 2026
@hkershaw-brown
Copy link
Member Author

No rush on this, checking everything builds, which nearly everything does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

back burner very low priority. Future work?

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Programs that do not routinely get built because they are not included in any quickbuild.sh

1 participant