Lonely programs that are not routinely built with existing quickbuild.shs get a quickdbuild.sh#1070
Open
hkershaw-brown wants to merge 5 commits intomainfrom
Open
Lonely programs that are not routinely built with existing quickbuild.shs get a quickdbuild.sh#1070hkershaw-brown wants to merge 5 commits intomainfrom
hkershaw-brown wants to merge 5 commits intomainfrom
Conversation
….shs partial fix for #1068. This is the programs not in the system_simulation directory
The quickbuild.sh is in developer tests. This is because the system similution codes do not follow the layout of other dart programs. In addition, I do not think they actually need much of dart (only random sequences). Unclear if they should be using types_mod. So build could be simplified further (no preprocess) see #1068
changed to .d0 to be double precision. see #1068 (comment)
Member
Author
|
No rush on this, checking everything builds, which nearly everything does. |
to not ignore It would be cooler if dart used an extension for executables
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
There are several (~31) programs that are not routinely built with existing quickbuild.sh so are not built with run_all_quickbuilds. This pull request adds two developer_test directories:
quickbuild.sh builds the programs not caught by dart quickbuild.shs
quickdbuild.sh builds the programs in assimilation_code/programs/system_simulation
Using the dev_test in quickdbuild.sh because the system simulation codes do not follow the layout of other dart programs.
In addition, I do not think they actually need much of dart (only random sequences). Unclear if they should be using types_mod. So build could be simplified further (no preprocess), but this pull request just uses the bog standard dart build, preprocess + build.
Fixes issue
fixes #1068
Two of the system_similation programs did not compile because they had _r8 but are not using types_mod, these have been changed to .d0
Types of changes
Documentation changes needed?
Tests
Please describe any tests you ran to verify your changes.
run_all_quickdbuild.sh
https://github.com/NCAR/DART/actions/runs/22865933793
Checklist for merging
Checklist for release
Testing Datasets