Some small bugs in feature/eCAI are fixed#16
Some small bugs in feature/eCAI are fixed#16guoqiang-tang wants to merge 8 commits intoNCAR:feature/eCAIfrom
Conversation
| y (i) = prcp_data (i, t) | ||
| y_tmean (i) = (tair_data(1, i, t)+tair_data(2, i, t)) / 2.0d0 | ||
| y_trange (i) = abs (tair_data(2, i, t)-tair_data(1, i, t)) | ||
| y_trange (i) = tair_data(2, i, t)-tair_data(1, i, t) |
There was a problem hiding this comment.
The abs() was included in the case that Tmax is larger than Tmin in the input files. We can remove it but that may allow for negative DTR...
There was a problem hiding this comment.
We should really add a warning to the user and then stop the program if Tmax > Tmin.
There was a problem hiding this comment.
I tend to want to avoid putting in an if statement at the most granular data levels ... I think I would leave the abs in but if there is a way to also check for temperature flips at a field/vector level, perhaps once per timestep, and report if any are found, that might be preferable.
anewman89
left a comment
anewman89
left a comment
There was a problem hiding this comment.
As far as I can tell, there is no way for me to ignore specific files or commits at this point. I think you'll have to create a new branch and add only the specific bug fix files.
3 participants
Corrections are made in estimate_climo_anom_regression.f90, estimate_climo_regression.f90, and estimate_forcing_regression.f90. Other files added in /downscale and /from_NR are used to support compiling in my machines and can be ignored when merging.