Skip to content

Sfclay+gwdo+shysu : starting from PR8#17

Open
Songyou184 wants to merge 2 commits intoNCAR:mainfrom
Songyou184:SFCLAY+GWDO+SHYSU
Open

Sfclay+gwdo+shysu : starting from PR8#17
Songyou184 wants to merge 2 commits intoNCAR:mainfrom
Songyou184:SFCLAY+GWDO+SHYSU

Conversation

@Songyou184
Copy link
Contributor

No description provided.

@islas
Copy link
Collaborator

islas commented Mar 12, 2026

@Songyou184 I think you forgot to add the bl_shinhong.F90 changes in this commit: 65ca8d7 Can you update your branch and make these changes?

Please make sure to pull the changes I made to correct the branch before pushing any changes.

@Songyou184
Copy link
Contributor Author

Songyou184 commented Mar 12, 2026 via email

@islas islas force-pushed the SFCLAY+GWDO+SHYSU branch from f72f99a to 1385eb0 Compare March 13, 2026 00:17
@islas islas requested review from dudhia and weiwangncar March 13, 2026 00:27
 	modified:   Makefile.mpas
 	bl_shinhong.F90
@islas islas force-pushed the SFCLAY+GWDO+SHYSU branch from 535e00e to 38222b9 Compare March 13, 2026 22:56
@weiwangncar
Copy link
Collaborator

The regression test results:

Test Type              | Expected  | Received |  Failed
= = = = = = = = = = = = = = = = = = = = = = = =  = = = =
Number of Tests        : 23           24
Number of Builds       : 60           57
Number of Simulations  : 158           150        0
Number of Comparisons  : 95           86        0

Failed Simulations are: 
None
Which comparisons are not bit-for-bit: 
None

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants