MARBL OBC Segments w/ Generic Tracers#404
Conversation
|
Figured out why it's not bit-for-bit with the previous implementation! The initialize_segment_data runs before the registering of MARBL tracer segments so in the previous implementation initialize_segment_Data included MARBL tracers but the new version doesn't. You get slightly different results, but both are realistic values. It would be interesting to see if other models use initialize_Segment_data or not. So not sure if we should fix it or leave it! (Probably should fix it, it's obvious initlaize_sgment_data expects generic tracers) There doesn't seem to be earlier calls to tracer_flow_control, so I'm not sure where we should move the tracers calls, which is why it would be good to see other implementations. |
|
The push to MOM.F90 is how to make it bit-for-bit |
|
Looking here, it seems like this implementation doesn't run with initalize_segment_Data either https://github.com/NOAA-GFDL/ocean_BGC/blob/main/generic_tracers/MOM_generic_tracer.F90 |
Description:
Changes required for MARBL regionally & Alper's change so that GLOFAS runoff will work.
Changes:
register_MARBL_tracer_segmentsthat reads the parameter file and registers the correct MOM_open_boundary functions to read from files.get_marbl_obc_paramsto read MARBL OBC tracers from the parameter file. Parameters need to be of the formOBC_DATA_{tracer}={filename}({variablename})initialize_marbl_tracersto properly initialize the OBC reservoirs