Merge CLUBB-MF into stormspeed for improved high resolution convection

[jtruesdal]

Merging the clubbmf branch into stormspeed. The branch is bit for bit with the ESCOMP SE regression testing when the default for aircraft_forcings%weight_by_lat is returned to its previous incorrect default of .true.
weight_by_lat should only be true for FV runs. It gives incorrect results for unstructured grids.

This is the first cut at merging in clubb_mf into stormspeed. There will likely be refactoring and tuning mods but the parameterization can now be tested and developed in stormspeed.

[Copilot]

Pull request overview

Copilot reviewed 16 out of 18 changed files in this pull request and generated 2 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 16 out of 18 changed files in this pull request and generated 1 comment.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 16 out of 18 changed files in this pull request and generated 1 comment.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 16 out of 18 changed files in this pull request and generated no new comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 17 out of 19 changed files in this pull request and generated 1 comment.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[jtruesdal]

Thanks Adam that makes perfect sense. jt

…

On Tue, Jan 13, 2026 at 10:53 AM Adam Herrington ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In src/physics/cam/clubb_mf.F90 <#73 (comment)>: > +! ! +! end do +! + + ddcp(:) = 0._r8 + if (do_clubb_mf_coldpool .and. clubb_mf_fdd > 0._r8) then + ! use single level for cold pool param. + ! reset ddcp + do i=1,clubb_mf_nup + if (ddbot(i) == 0) then + continue + else + if (do_clubb_mf_coldpool_perplume) then + ddcp(i) = -1._r8*dnw(ddbot(i)+1,i) + else + ddcp(:) = ddcp(:) + -1._r8*dna(ddbot(i)+1,i)*dnw(ddbot(i)+1,i) I believe it's correct as is. When do_clubb_mf_coldpool_perplume=.false. the cold pool feedback is not a function of ensemble plume member, i; the same value of ddcp is applied to all ensemble members. That value of ddcp is the ensemble integrated downdraft speed. — Reply to this email directly, view it on GitHub <#73 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACG3NX5DLPWBRW45PGBGZOL4GUWIDAVCNFSM6AAAAACPQDLUSKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTMNJXGEYDGNJWHA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[jtruesdal]

@sjsprecious We are ready to commit this but are failing some of the tests. I'm not sure if we need these passing before pulling the trigger.

[jtruesdal]

@sjsprecious weird when I refreshed the page the two failing tests are now gone. Not sure what happened. I guess there is nothing to look at.

[sjsprecious]

Thanks @jtruesdal . I have no idea about clubb-mf but since you and Adam are fine with the results and all CI tests pass, I am happy to approve and merge this PR.