Skip to content

Add back nvhpc25.7 image#78

Merged
sjsprecious merged 3 commits intostormspeedfrom
add_back_nvhpc257_image
Feb 27, 2026
Merged

Add back nvhpc25.7 image#78
sjsprecious merged 3 commits intostormspeedfrom
add_back_nvhpc257_image

Conversation

@sjsprecious
Copy link
Collaborator

This PR adds back the nvhpc/25.7 image, since the nvhpc/26.1 compiler changes some restrictions on the OpenACC code and may crash some existing code used at NCAR.

Copilot AI review requested due to automatic review settings February 26, 2026 22:09
@sjsprecious sjsprecious self-assigned this Feb 26, 2026
@sjsprecious sjsprecious added the ready_for_ci This PR is ready for CI tests on CIRRUS cloud label Feb 26, 2026
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reintroduces an Ubuntu 24.04 NVHPC 25.7 GPU container image (OpenMPI 5.0.8 + CUDA 12.9) to preserve compatibility with existing OpenACC workloads that are impacted by NVHPC 26.1 behavior changes.

Changes:

  • Adds a new ubuntu24.04_nvhpc25.7_openmpi5.0.8_cuda12.9 Dockerfile that builds the StormSPEED CAM software stack with Spack.
  • Updates the image-build GitHub Actions workflow matrix to include the newly added Dockerfile.
  • Updates some existing Dockerfiles to clone Spack at tag v1.1.0.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
dockerfiles/Dockerfile.ubuntu24.04_nvhpc25.7_openmpi5.0.8_cuda12.9 New NVHPC 25.7 + OpenMPI 5.0.8 + CUDA 12.9 container build recipe via Spack.
dockerfiles/Dockerfile.opensuse15_gcc12_openmpi5.0.8_cpu Bumps Spack clone tag from v1.0.0 to v1.1.0.
dockerfiles/Dockerfile.almalinux9.6_intel2024_openmpi5.0.8_cpu Bumps Spack clone tag from v1.0.0 to v1.1.0.
.github/workflows/build_image_workflow.yml Adds the new Dockerfile to the build matrix and enables pull_request triggering.
.github/workflows/build_and_run_workflow.yml Comments out the pull_request trigger for the build-and-run workflow.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings February 26, 2026 23:50
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions github-actions bot removed the ready_for_ci This PR is ready for CI tests on CIRRUS cloud label Feb 27, 2026
@github-actions
Copy link

CI Test Failed

I have removed the ready_for_ci label to prevent wasted resources.

Action Required:

  1. Check the GitHub Actions logs for errors.
  2. Fix the issues and push new commits.
  3. Re-apply the ready_for_ci label to restart the build.

@sjsprecious sjsprecious added the ready_for_ci This PR is ready for CI tests on CIRRUS cloud label Feb 27, 2026
@sjsprecious sjsprecious merged commit ed2a8a2 into stormspeed Feb 27, 2026
39 of 43 checks passed
@sjsprecious sjsprecious deleted the add_back_nvhpc257_image branch February 27, 2026 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready_for_ci This PR is ready for CI tests on CIRRUS cloud

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants