Conversation
There was a problem hiding this comment.
Pull request overview
This PR reintroduces an Ubuntu 24.04 NVHPC 25.7 GPU container image (OpenMPI 5.0.8 + CUDA 12.9) to preserve compatibility with existing OpenACC workloads that are impacted by NVHPC 26.1 behavior changes.
Changes:
- Adds a new
ubuntu24.04_nvhpc25.7_openmpi5.0.8_cuda12.9Dockerfile that builds the StormSPEED CAM software stack with Spack. - Updates the image-build GitHub Actions workflow matrix to include the newly added Dockerfile.
- Updates some existing Dockerfiles to clone Spack at tag
v1.1.0.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
dockerfiles/Dockerfile.ubuntu24.04_nvhpc25.7_openmpi5.0.8_cuda12.9 |
New NVHPC 25.7 + OpenMPI 5.0.8 + CUDA 12.9 container build recipe via Spack. |
dockerfiles/Dockerfile.opensuse15_gcc12_openmpi5.0.8_cpu |
Bumps Spack clone tag from v1.0.0 to v1.1.0. |
dockerfiles/Dockerfile.almalinux9.6_intel2024_openmpi5.0.8_cpu |
Bumps Spack clone tag from v1.0.0 to v1.1.0. |
.github/workflows/build_image_workflow.yml |
Adds the new Dockerfile to the build matrix and enables pull_request triggering. |
.github/workflows/build_and_run_workflow.yml |
Comments out the pull_request trigger for the build-and-run workflow. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
❌ CI Test Failed I have removed the Action Required:
|
This PR adds back the nvhpc/25.7 image, since the nvhpc/26.1 compiler changes some restrictions on the OpenACC code and may crash some existing code used at NCAR.