Skip to content

Adding some information on Standard Names for dimensions in metadata files#80

Open
mkavulich wants to merge 2 commits intoNCAR:mainfrom
mkavulich:add_dimensions_info
Open

Adding some information on Standard Names for dimensions in metadata files#80
mkavulich wants to merge 2 commits intoNCAR:mainfrom
mkavulich:add_dimensions_info

Conversation

@mkavulich
Copy link
Collaborator

As part of the ESM Standard Names reorganization (PR incoming), I noticed a lot of CCPP-specific information about dimensions was stored there, that should more properly be located in the CCPP tech doc. This PR adds that information.

Comment on lines +404 to +405
[dim_name]_begin:[dim_name]_end ==> 1:[dim_name]_loop_extent
[dim_name]_begin:[dim_name]_end ==> 1:[dim_name]_dimension
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know what you mean (because I wrote ccpp-prebuild), but for most people this will be confusing and scary. We need to explain that the left side (slices of the entire array allocated by the host model) in the CCPP run phase are sent to the CCPP physics scheme for parallel processing using OpenMP threading, and that schemes require the horizontal "dimension" for the current call to run from 1 to the length of the slice. I hope you can explain that better; some of it may already be explained in the next section (It is important to understand the difference between horizontal_dimension vs. horizontal_loop_extent), in which case we should refer to that section.

Comment on lines +408 to +409
but not in xxx_run routines. Currently, the only dimension which supports all
six dimension types is horizontal_dimension.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really understand what you mean with the last sentence, but I don't it's correct and it should probably be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants