Improve parsing of Fortran array specifications#687
Merged
mkavulich merged 6 commits intoNCAR:developfrom Nov 5, 2025
Merged
Conversation
gold2718
requested review from
climbfuji,
dustinswales,
grantfirl,
mkavulich,
mwaxmonsky and
peverwhee
as code owners
Collaborator
|
@gold2718 Is this still a work in progress? I see that the CI is not passing. |
added 2 commits
October 9, 2025 22:36
…e_errors Merge up to head of develop to ensure tests still pass
Collaborator
Author
|
@mkavulich, sorry about that, I had forgotten about this. It turns out that a last piece of the development was never committed and uploaded. I did that and also merged up to develop to make sure this is (I hope) ready to go now. |
climbfuji
approved these changes
Oct 9, 2025
Collaborator
climbfuji
left a comment
climbfuji
left a comment
There was a problem hiding this comment.
Thanks very much for fixing this!
Collaborator
peverwhee
approved these changes
Oct 23, 2025
Collaborator
Author
|
@mkavulich, is this ready to move forward? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve parsing of Fortran array specifications
capgen was reporting odd errors when a semi-colon typo appeared in the middle of an
array specification.
This is due to the fact that the semi-colon is a Fortran special character used to separate statements making it possible to have multiple statements on a single source line.
This PR allows semi-colons to appear in parentheses in a statement.
To have this result in a more useful parsing error, some refactoring was done on how the Fortran parser collects and displays errors (an onion peel I have wanted to do for a while although there is plenty of onion left).
User interface changes?: No
Fixes: #362
Testing:
test removed:
unit tests:
system tests:
manual testing: