Skip to content

Fix TypeError when reporting ParseSyntaxError in parse_fortran_var_decl #726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jimmielin wants to merge 2 commits into
base: develop
Choose a base branch
from
+3 −1
Open

Fix TypeError when reporting ParseSyntaxError in parse_fortran_var_decl #726

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0b92a8d
Fix TypeError when reporting ParseSyntaxError in parse_fortran_var_decl
jimmielin Mar 15, 2026
22e37f4
Add doctest testing for integer dimension indices
jimmielin Mar 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion scripts/fortran_tools/parse_fortran.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -701,6 +701,8 @@ def parse_fortran_var_decl(line, source, run_env, imports=None):
['8']
>>> parse_fortran_var_decl("character(len=*), intent(out) :: errmsg", ParseSource('foo.F90', 'module', ParseContext()), _DUMMY_RUN_ENV)[1][0]
'Syntax error: Invalid variable declaration, character(len=*), intent(out) :: errmsg, intent not allowed in module variable, in <standard input>'
>>> parse_fortran_var_decl("type(banana_t) :: bananas(0:N_FRUITS)", ParseSource('foo.F90', 'module', ParseContext()), _DUMMY_RUN_ENV)[1][0]
"bananas: '0:N_FRUITS' is an invalid dimension name; integer dimension indices not supported, in <standard input>"

## NB: Expressions (including function calls) not currently supported here
#>>> parse_fortran_var_decl("real(kind_phys), intent(out) :: foo(size(bar))", ParseSource('foo.F90', 'scheme', ParseContext()), _DUMMY_RUN_ENV)[0].get_prop_value('dimensions')
Expand Down Expand Up @@ -814,7 +816,7 @@ def parse_fortran_var_decl(line, source, run_env, imports=None):
fortran_imports=imports)
newvars.append(var)
except ParseSyntaxError as perr:
errors.append(perr)
errors.append(str(perr))
# end try
# end for
# No else (not a variable declaration)
Expand Down
Loading