DRAFT FOR DOM: Feature/capgen_for_fuji#1192
Conversation
…ure/changes_for_capgen
…ure/changes_for_capgen
…ure/capgen_for_fuji
dustinswales
requested review from
AndersJensen-NOAA,
grantfirl,
haiqinli,
joeolson42,
lisa-bengtsson,
mjiacono,
rhaesung and
tanyasmirnova
as code owners
| dimensions = (number_of_active_gases_used_by_RRTMGP) | ||
| type = character | ||
| kind = len=128 | ||
| kind = len=* |
There was a problem hiding this comment.
Nice to see that the Metadata-vs-Fortran validation works and fixes so many inconsistencies!
| !! \section arg_table_myjpbl_wrapper_init Argument Table | ||
| !! \htmlinclude myjpbl_wrapper_init.html | ||
| !! |
There was a problem hiding this comment.
All these schemes with missing metadata tables simply didn't get called in prebuild, or?
There was a problem hiding this comment.
This wouldn't be an "error" in Prebuild, but the scheme call wouldn't get added to the Cap.
None of the scheme files missing metadata hooks here are currently used in UFS applications, so this was just added to pass the meta/fortran comparison w/o removing anything. I could go the other route and remove the tables from the metadata files?
| ! MPI variables | ||
| integer :: mpiid | ||
| type(MPI_comm), intent(in) :: mpicomm | ||
| type(MPI_Comm), intent(in) :: mpicomm |
There was a problem hiding this comment.
all this must be case-insensitive
There was a problem hiding this comment.
Hmm. Let me double check this. It may be a relic.
2 participants
@climbfuji Physics changes for Capgen.
Mostly metadata/fortran inconsistencies.
One thing I had to change was the LSM integer identifier local_name (e.g., lsm_noah -> ilsm_noah). This was a problem in the Capgen Suite caps when the scheme name was the same as the local name, so I added the "i" suffix. Note, we shouldn't need this when the DDT approach within Capgen is implemented.