Conversation
nesting (moving-nesting) configurations, while reading in lw/sw_file_gas/clouds files.
options of tc_rain and tc_snow for adjustments of max terminal fall speeds of rain and snow under TC conditions.
Add RRTMGP initialization flags and revert hardcoding of mpiroot
….meta so that convective adjustment time can be tunable, introducing two parameters cat_adj_deep and cat_adj_shal for this
rain and snow in Thompson MP scheme
…eepcnv.meta and samfshalcnv.meta.
This reverts commit 2aa85ba.
This reverts commit 01898e4.
Clean up sfcsub.F: remove unused code, comments, and developer tags
scrasmussen
requested review from
AndersJensen-NOAA,
dustinswales,
grantfirl,
lisa-bengtsson,
mdtoyNOAA,
rhaesung and
tanyasmirnova
as code owners
grantfirl
left a comment
grantfirl
left a comment
There was a problem hiding this comment.
Approving because the changes are identical to the ufs-community PR, noting that the RRTMGP moving nest MPI problem is using a temporary solution: see ufs-community#352 that was added to address the issue more completely in the future.
…esentative for NRL
| # Default codeowners for files that don't have specific owners: | ||
|
|
||
| * @grantfirl @rhaesung @Qingfu-Liu @dustinswales @mzhangw | ||
| * @grantfirl @rhaesung @Qingfu-Liu @dustinswales @mzhangw @climbfuji |
| mpirank, & !< Current MPI rank | ||
| mpiroot !< Master MPI rank | ||
| mpiroot1 !< Master MPI rank | ||
| integer :: mpiroot |
There was a problem hiding this comment.
I am still a little uncomfortable with a locally defined MPI communicator, but for now (until I understand this better), I think it's ok.
There was a problem hiding this comment.
Ditto. But I had no way of testing alternatives.
There is now(?) a HAFSv2 RT with GP enabled, so I will be able to revisit this.
There was a problem hiding this comment.
I actually couldn't find a RT that runs the HAFS_v2 suite. I know that the SDF was added, but I don't see an RT for it.
9 participants
Dependencies:
Parent PRs, note this is build on top of #1194 and that should be merged first
ufs-community/ccpp-physics
NOAA-EMC/ufsatm
ufs-community/ufs-weather-model