Merged
Conversation
- installing OpenMPI v4.1.6 manually, making MPI compiler default - installing curl, zlibs with apt-get - bumping actions' versions - quite wget and tarball expansion - caching and PATH, LD_LIBRARY_PATH setting changes fix fix
scrasmussen
requested review from
dustinswales,
grantfirl and
mkavulich
as code owners
grantfirl
approved these changes
Jul 1, 2024
Collaborator
grantfirl
left a comment
grantfirl
left a comment
There was a problem hiding this comment.
This looks good to me @scrasmussen. It looks like it's failing at the point where #486 should fix it. @dustinswales Would you review this since you were working on this?
dustinswales
approved these changes
Jul 1, 2024
Member
dustinswales
left a comment
dustinswales
left a comment
There was a problem hiding this comment.
@scrasmussen
This looks good to me. Thanks for fixing this.
(Hopefully this is the last of the non-containerized CI test we fix!)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing Github runner nvidia MPI installation and caching. List of changes
PATHandLD_LIBRARY_PATHvariable setting. Separated from build stepsNOTE: nvidia-with-GPU build still fails