Conversation
…be called from other python scripts; add an option to override the paths within the bundle to be all the same, to use for packaging non-.app tools. All still experimental.
…x_app_bundle_paths to check for secondary dependencies
Contributor
|
Thanks @isabel Suhr ***@***.***> . I will let you know if I see
anything amiss.
…On Wed, Mar 11, 2026 at 4:23 PM Isabel Suhr ***@***.***> wrote:
@janineA <https://github.com/janineA> I just wanted to let you know that
I've made some updates to this script (to make it also usable for deploying
non-app-bundle-structured commandline aspen). Default behavior should be
unchanged and it's still working fine for app bundles for me, but I wanted
to give you a heads up in case you notice anything weird.
------------------------------
You can view, comment on, or merge this pull request online at:
#6
Commit Summary
- 154d087
<154d087>
Move parsing commandline args out of AppBundleChecker so it can also be
called from other python scripts; add an option to override the paths
within the bundle to be all the same, to use for packaging non-.app tools.
All still experimental.
- c6dcc77
<c6dcc77>
Check dependencies of any library that gets added to the bundle in
fix_app_bundle_paths to check for secondary dependencies
- 4e0ccc6
<4e0ccc6>
Oops, remove check of new_library_path that's now handled in
get_new_library_path()
File Changes
(1 file <https://github.com/NCAR/eol_scons/pull/6/files>)
- *M* scripts/fix_app_bundle_paths.py
<https://github.com/NCAR/eol_scons/pull/6/files#diff-551d6505661d2a91414f6023be2fe8c2a99e2a3a3069d8dc25726763a4edf0b1>
(95)
Patch Links:
- https://github.com/NCAR/eol_scons/pull/6.patch
- https://github.com/NCAR/eol_scons/pull/6.diff
—
Reply to this email directly, view it on GitHub
<#6>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABFBJKQ6YWWT5MAOILZAHY34QHRM7AVCNFSM6AAAAACWO3MPEGVHI2DSMVQWIX3LMV43ASLTON2WKOZUGA3DCMBSHAYTQOI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
@}-,-'--
My working day may not be your working day. Please do not feel obliged to
reply to this email outside of your normal working hours.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@janineA I just wanted to let you know that I've made some updates to this script (to make it also usable for deploying non-app-bundle-structured commandline aspen). Default behavior should be unchanged and it's still working fine for app bundles for me, but I wanted to give you a heads up in case you notice anything weird.