Skip to content

Added test for uk_nhs#51

Open
jpow2 wants to merge 3 commits intomainfrom
14-detect-uk_nhs-1
Open

Added test for uk_nhs#51
jpow2 wants to merge 3 commits intomainfrom
14-detect-uk_nhs-1

Conversation

@jpow2
Copy link
Copy Markdown

@jpow2 jpow2 commented Mar 22, 2024

No description provided.

@jpow2 jpow2 linked an issue Mar 22, 2024 that may be closed by this pull request
@jpow2 jpow2 requested review from Kyeeshaaa and claesmk March 22, 2024 17:05
@jpow2 jpow2 self-assigned this Mar 22, 2024
@jpow2 jpow2 added the Team2 label Mar 22, 2024
@jpow2 jpow2 added this to the Sprint-2 milestone Mar 22, 2024
Copy link
Copy Markdown
Contributor

@claesmk claesmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your negative test case is still detecting a possible UK_NHS - please change to something else which is not detected.

@claesmk
Copy link
Copy Markdown
Contributor

claesmk commented Mar 25, 2024

@jpow2 reminder you still need to update your negative test case

Copy link
Copy Markdown
Contributor

@oeoloyede oeoloyede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the negative test case

@jpow2
Copy link
Copy Markdown
Author

jpow2 commented Apr 11, 2024

Added the negative test cases but the syncing is not working properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Detect UK_NHS

4 participants