Skip to content

13 detect sg uen2#84

Open
oryange23-png wants to merge 2 commits intomainfrom
13-detect-sg_uen2
Open

13 detect sg uen2#84
oryange23-png wants to merge 2 commits intomainfrom
13-detect-sg_uen2

Conversation

@oryange23-png
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown

@SnosAlias SnosAlias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall the code provided is strong in showcasing the positive and negative cases of SG_UEN. I would only suggest a couplw changes for clarity, but they are not required as the program works fine without them:

  1. Separating the test case loop from iterating over the valid and invalid samples, so output isn’t mixed in case later readjustment is needed.
  2. Separation of test functions provides clearer output of working cases vs failure.

Neither of these are required, but they just provide better readability, good work.

Copy link
Copy Markdown
Contributor

@claesmk claesmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK - don't forget to add the correct milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants