Merged
Conversation
Closed
claesmk
approved these changes
Jul 18, 2025
Contributor
claesmk
left a comment
claesmk
left a comment
There was a problem hiding this comment.
Made one change for you to make sure the test fails if CRYPTO is not detected - you don't want to bypass that. The original implementation could pass even if CRYPTO was not detected
claesmk
approved these changes
Jul 18, 2025
ItsArixy
approved these changes
Jul 18, 2025
Contributor
|
@milesmjohnson are you going to "Update branch" and merge this PR? |
Contributor
Author
|
My apologies, I thought I did. Will do when I get home.
Have a great weekend,
Miles
…On Fri, Jul 18, 2025 at 7:43 PM claesmk ***@***.***> wrote:
*claesmk* left a comment (NCATComp410/comp410_summer_2025#32)
<#32 (comment)>
@milesmjohnson <https://github.com/milesmjohnson> are you going to
"Update branch" and merge this PR?
—
Reply to this email directly, view it on GitHub
<#32 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BPNHL3YFQGC3AIDDVPRDIKL3JGBBTAVCNFSM6AAAAACBZINWIKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTAOJRGI3DENJVGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Contributor
|
@milesmjohnson are you still planning to take care of this update and merge? |
Contributor
Author
|
@claesmk completed the update and merge. |
Contributor
|
@milesmjohnson don't forget to delete your development branch - that's 10% of the grade |
Contributor
Author
|
@claesmk just deleted. Thank you for allowing me to do so. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.