Skip to content

12 detect us bank number#33

Merged
Robrei2004 merged 6 commits intomainfrom
12-detect-us_bank_number
Jul 19, 2025
Merged

12 detect us bank number#33
Robrei2004 merged 6 commits intomainfrom
12-detect-us_bank_number

Conversation

@Robrei2004
Copy link
Copy Markdown
Contributor

No description provided.

@Robrei2004 Robrei2004 added this to the Sprint-2 milestone Jul 18, 2025
@Robrei2004 Robrei2004 requested a review from claesmk July 18, 2025 00:47
@Robrei2004 Robrei2004 self-assigned this Jul 18, 2025
@Robrei2004 Robrei2004 linked an issue Jul 18, 2025 that may be closed by this pull request
Copy link
Copy Markdown
Contributor Author

@Robrei2004 Robrei2004 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the one I keep pushing but it is not changing in the commits

@Robrei2004
Copy link
Copy Markdown
Contributor Author

@boltydev @claesmk @ktrattley, do you know how to redo the approval request? Every time I create a new codespace, it fails to load on the testing 0/0 instead of 22/22.

Copy link
Copy Markdown
Contributor

@claesmk claesmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected US_BANK_NUMBER

@claesmk claesmk requested review from boltydev and ktrattley July 18, 2025 23:45
@claesmk
Copy link
Copy Markdown
Contributor

claesmk commented Jul 18, 2025

@Robrei2004 I pushed some code earlier which should resolve your problems. The issue is you are still waiting on someone from your team to review. After that you should be able to merge OK

Copy link
Copy Markdown
Contributor

@boltydev boltydev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good!

@claesmk
Copy link
Copy Markdown
Contributor

claesmk commented Jul 19, 2025

@Robrei2004 you are all set to "Update branch" and merge this PR

@Robrei2004 Robrei2004 merged commit 6140692 into main Jul 19, 2025
1 check passed
@Robrei2004 Robrei2004 deleted the 12-detect-us_bank_number branch July 19, 2025 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Detect US_BANK_NUMBER

3 participants