Open
Conversation
Contributor
Author
|
@clintonoadebomi I thought you might like to participate in this code review. This issue explains what happened when the Presidio team make a change to the default recognizers. This is why most of your team's recognizers disappeared and needed to be added manually. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive unit tests for the PII scan module to verify base functionality and resolves issues introduced by Presidio version 2.2.359. The changes include new test coverage, additional recognizer imports, and minor formatting improvements.
- Adds comprehensive test suite with entity verification, naming convention validation, and basic functionality tests
- Updates imports to include new Indian and UK recognizers to fix compatibility issues
- Improves code formatting and removes unnecessary whitespace
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| test_pii_scan.py | New comprehensive test file with entity verification, test naming validation, and basic functionality tests |
| pii_scan.py | Adds imports and registry entries for new Indian and UK recognizers, improves function parameter formatting |
| test_team_2.py | Removes unnecessary blank line for cleaner formatting |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add some checks to make sure base functionality working as expected and fix issues caused by 2.2.359