inactive: Make component optionally a list#8
inactive: Make component optionally a list#8cbizon wants to merge 1 commit intoNCATSTranslator:mainfrom
Conversation
Many teams use BTE (identified as an ARA) as a KP since it provides a trapi interface to non-trapi services. This requires special casing in the calling ARAs, so it would be nice if BTE were able to identify as both a KP and an ARA in the registry. This change would allow that. For simplicity, but at the cost of losing backwards compatibility, the oneOf could be removed in place of just converting the string value of component to an array value.
|
@andrewsu to comment on the code-breaking part. |
|
@cbizon after discussion at our team meeting, we propose not making this change at this time, for two reasons. First, since allowing multiple values would only apply to BTE right now (right?), it seems better to handle that as a special case rather than change the spec. Second, this change would break our SmartAPI metakg tool, and given pressing timelines, we'd rather not have to add another thing to our plate. We do understand the potential benefits to consumers by making this change, but given that ARAs that want to call BTE as a KP have already implemented whatever special logic they need to get things to work, we propose to delay this until at least after the December demo. Are there other factors that we aren't considering here? |
|
No, I don't know of any other factors. I think that's a reasonable approach. |
|
Leaving this PR open as a "phantom"/"inactive", to potentially revisit later. |
Many teams use BTE (identified as an ARA) as a KP since it provides a trapi interface to non-trapi services. This requires special casing in the calling ARAs, so it would be nice if BTE were able to identify as both a KP and an ARA in the registry. This change would allow that.
For simplicity, but at the cost of losing backwards compatibility, the oneOf could be removed in place of just converting the string value of component to an array value.