Course Credit Calculator #2118
Course Credit Calculator #2118
Conversation
spec/factories/activities.rb
Outdated
| @@ -11,6 +11,7 @@ | |||
| always_on { false } | |||
| retired { false } | |||
| self_verification_info { nil } | |||
| duration_in_hours { 2.5 } | |||
There was a problem hiding this comment.
I wonder if we should have this default to nil, as that currently the default behaviour we have on seeds, then maybe have a trait :with_duration?
There was a problem hiding this comment.
Just having a think about this. I need to test cs_accelerator cases with different durations (less than a day, more than one day).
Would it be cleaner to define the duration in hours when creating the activity for the individual test, rather than a trait? Otherwise I'd have to create multiple traits.
Eg. activity = create(:activity, programmes: [cs_accelerator_programme], duration_in_hours: 10)
There was a problem hiding this comment.
...and have the default to nil as suggested.
There was a problem hiding this comment.
Actually, ignore the above comments. I was repeating a lot of code when defining the duration on individual tests.
| @@ -231,4 +231,65 @@ | |||
| expect(activity.active_course?).to eq(false) | |||
| end | |||
| end | |||
|
|
|||
There was a problem hiding this comment.
We currently do not test that the credits are not changed if there is no duration in hours. As we use that as the primary criteria in the callback in the programme activity, would be good to test that behaviour
There was a problem hiding this comment.
I've added a test for this on line 246
|
Added additional testing
Added test for credit calculator to not change credits if there is no duration provided.
A-Wheeto
force-pushed
the
2737-course-credit-calculator-V2
branch
from
8e98ab5 to
6055b30
Compare
|
Status
Review progress:
What's changed?