Site Wide Banner #2403
Open
Site Wide Banner #2403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A-Wheeto
force-pushed
the
2922-introduce-a-sitewide-banner-feature
branch
from
8693289 to
4f9c130
Compare
New single cms resource New cms view component
…er to enter start time and end time for the banner Created site wide banner stub - added into spec helper Logic to check for current banners and display the latest one
Added date query into graphql Changed text to rich header to allow for links to be placed into the banners Added some testing on header and view component
A-Wheeto
force-pushed
the
2922-introduce-a-sitewide-banner-feature
branch
from
dbf30b6 to
dc9592b
Compare
|
|
Looks good, straightforward stuff 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Review progress:
What's changed?
Steps to perform after deploying to production
If the production environment requires any extra work after this PR has been deployed detail it here. This could be running a Rake task, migrating a DB table, or upgrading a Gem. That kind of thing.