(#14, #17) Fix linting for ecmascript modules. #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blairlearn
force-pushed
the
ticket/14-module-fix
branch
16 times, most recently
from
1016a95 to
19eff22
Compare
blairlearn
changed the title
bryanpizzillo
requested changes
Oct 20, 2025
Member
bryanpizzillo
left a comment
bryanpizzillo
left a comment
There was a problem hiding this comment.
There are a number of undocumented changes being made here. Also nothing in the standards workflow should reference a ref.
blairlearn
force-pushed
the
ticket/14-module-fix
branch
2 times, most recently
from
c07f5a2 to
1e62745
Compare
blairlearn
force-pushed
the
ticket/14-module-fix
branch
4 times, most recently
from
baea61c to
016a555
Compare
- BREAKING CHANGE: There is now a required parameter, config_ref, which specifies the branch, tag, or commit hash to use when retrieving the commitlint configuration file. Changes: - Run commitlint directly from workflow. - Rename commitlint config file to .cjs. - Parameterize standards check workflow. - Pass module version from test_commitlint workflow. - Bump action versions. - Adds explicit workflow permissions. Closes #14 Closes #17
blairlearn
force-pushed
the
ticket/14-module-fix
branch
from
016a555 to
4b308f4
Compare
bryanpizzillo
approved these changes
Oct 28, 2025
Member
bryanpizzillo
left a comment
bryanpizzillo
left a comment
There was a problem hiding this comment.
@jfrank-nih and @blairlearn say this works. Approach looks right
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is now a required parameter,
config_ref, which specifiesthe branch, tag, or commit hash to use when retrieving the
commitlint configuration file.
Changes:
Notes:
Why use commitlint directly instead of via an action?
The
wagoid/commitlint-github-actionaction has a bug/limitation (described in their issue 810) which prevents using a configuration file from outside the$GITHUB_WORKSPACEtree. This is a Docker action which mounts$GITHUB_WORKSPACE; making the runner's/tmpdirectory inaccessible.The bulk of the action's code appears to be calculating start and ending commits for linting, which is information GHA provides.
The commitlint documentation provides a guide for setting it up in GitHub actions.
Closes #14
Closes #17