(#4479) Fix token replacement for browser title. #4545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blairlearn
force-pushed
the
ticket/4479-round-2
branch
2 times, most recently
from
5289cec to
94507d2
Compare
blairlearn
force-pushed
the
ticket/4479-round-2
branch
2 times, most recently
from
3c61af3 to
e06b78c
Compare
ODE DeploymentCode has been deployed to ODE 1007. |
blairlearn
force-pushed
the
ticket/4479-round-2
branch
from
e06b78c to
3768601
Compare
blairlearn
force-pushed
the
ticket/4479-round-2
branch
2 times, most recently
from
a2a0e84 to
079ff75
Compare
blairlearn
force-pushed
the
ticket/4479-round-2
branch
from
079ff75 to
3a5ecd1
Compare
blairlearn
force-pushed
the
ticket/4479-round-2
branch
from
3a5ecd1 to
a26c976
Compare
bryanpizzillo
force-pushed
the
ticket/4479-round-2
branch
from
a26c976 to
e548f0b
Compare
blairlearn
force-pushed
the
ticket/4479-round-2
branch
from
e548f0b to
7ee9f55
Compare
Contributor
Author
|
Perhaps one day this will get merged. |
blairlearn
force-pushed
the
ticket/4479-round-2
branch
from
7ee9f55 to
6f5afda
Compare
blairlearn
force-pushed
the
ticket/4479-round-2
branch
2 times, most recently
from
14b59b9 to
e58913c
Compare
blairlearn
force-pushed
the
ticket/4479-round-2
branch
from
e58913c to
d61599f
Compare
blairlearn
force-pushed
the
ticket/4479-round-2
branch
from
d61599f to
baf39ab
Compare
blairlearn
force-pushed
the
ticket/4479-round-2
branch
from
baf39ab to
0f25f22
Compare
bryanpizzillo
force-pushed
the
ticket/4479-round-2
branch
2 times, most recently
from
61055b8 to
f9b2673
Compare
|
Custom site name values gets double encoded apostrophe on all app modules ( other content is fine ) |
When using \Drupal::token() within a hook_tokens() implementation, use replacePlain() instead of replace() in order to avoid multiple levels of HTML encoding. Pre-emptively address the same concern for sitename display type. Add comments describing the site name tokens. Better description for 'sitename-display-type-meta' token. Closes #4479
blairlearn
force-pushed
the
ticket/4479-round-2
branch
from
f9b2673 to
1d864ae
Compare
|
As discussed on 9/24: Moving this item and PR to on Hold, we are ramping down on non-critical digital platform updates until after the 4.2 article conversion release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Repairs a multi-level recursive escaping of HTML characters when resolving browser title tokens.
See #4479 for detailed testing notes and instructions.
Closes #4479