Skip to content

(#4614) Update CSS Comments for 16x9 Aspect Ratio #4672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
karlikpj wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

(#4614) Update CSS Comments for 16x9 Aspect Ratio #4672

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion docroot/profiles/custom/cgov_site/themes/custom/cgov/src/styles/_brp.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ $gray: #9e9e9e;
position: relative;
overflow: hidden;
height: 0;
/* 16:9 Aspect Ratio (divide 9 by 16 = 0.5625) x width 100% */
padding-bottom: 56.25%;

text-align: center;
Expand Down Expand Up @@ -273,9 +274,10 @@ $gray: #9e9e9e;
img {
width: 100%;
}
/* 16:9 Aspect Ratio (divide 9 by 16 = 0.5625) x width 100% */
padding-bottom: 56.25%;
}
}
}
}
}
}
2 changes: 1 addition & 1 deletion ...ot/profiles/custom/cgov_site/themes/custom/cgov/src/styles/_nci-foundation_variables.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -435,7 +435,7 @@ $flex-video-padding-top: em-calc(0);
// $flex-video-margin-bottom: em-calc(16);

// We use this to control widescreen bottom padding

/* 16:9 Aspect Ratio (divide 9 by 16 = 0.5625) x width 100% */
$flex-video-widescreen-padding-bottom: 56.25%;

//
Expand Down
1 change: 1 addition & 0 deletions ..._site/themes/custom/ncids_trans/front-end/src/entrypoints/ckeditor/ckeditor-ck-scope.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,6 +258,7 @@ figure {
.flex-video {
margin-bottom: 0;
position: relative;
/* 16:9 Aspect Ratio (divide 9 by 16 = 0.5625) x width 100% */
padding-bottom: 56.25%;
padding-top: 0px;
overflow: hidden;
Expand Down
2 changes: 1 addition & 1 deletion ...site/themes/custom/ncids_trans/front-end/src/legacy/styles/_nci-foundation_variables.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,7 +413,7 @@ $flex-video-padding-top: em-calc(0);
// $flex-video-margin-bottom: em-calc(16);

// We use this to control widescreen bottom padding

/* 16:9 Aspect Ratio (divide 9 by 16 = 0.5625) x width 100% */
$flex-video-widescreen-padding-bottom: 56.25%;

//
Expand Down
9 changes: 5 additions & 4 deletions ..._site/themes/custom/ncids_trans/front-end/src/lib/components/cgdp-inline-video/index.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,7 @@
// removed for audio described link
// overflow:hidden
@include u-padding-top(0);
// Legacy css - we shoulnt use percents
// todo - clean up to use tokens
/* 16:9 Aspect Ratio (divide 9 by 16 = 0.5625) x width 100% */
padding-bottom: 56.25%;
background-color: color($theme-color-accent-cool-darker);

Expand All @@ -25,8 +24,9 @@
}

&__audio_described {
// Legacy css - we shoulnt use percents
// todo - clean up to use tokens

/* 16:9 Aspect Ratio (divide 9 by 16 = 0.5625) x width 100% */
/* plus the extra height for audio described */
padding-bottom: calc(56.25% + 48px);
}

Expand Down Expand Up @@ -75,6 +75,7 @@
@include u-margin-bottom(0);
overflow: hidden;
@include u-padding-top(0);
/* 16:9 Aspect Ratio (divide 9 by 16 = 0.5625) x width 100% */
padding-bottom: 56.25%;
background-color: color($theme-color-accent-cool-darker);

Expand Down
1 change: 1 addition & 0 deletions ...om/cgov_site/themes/custom/ncids_trans/front-end/src/lib/components/cgdp-video/index.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
margin-bottom: 0;
overflow: hidden;
padding-top: 0;
/* 16:9 Aspect Ratio (divide 9 by 16 = 0.5625) x width 100% */
padding-bottom: 56.25%;
background-color: color($theme-color-accent-cool-darker);

Expand Down