Skip to content

Conversation

@bkline
Copy link
Contributor

@bkline bkline commented Aug 22, 2025

In pdq_cancer_information_summary/src/OrphanCleanup.php:

  • remove line of code inadvertently copied from another method
  • reassure PHP (and phpstan) that we have the the right interface for invoking deleteRevision()

Closes #4815

@bkline bkline requested a review from blairlearn August 22, 2025 16:02
@bkline bkline requested a review from a team as a code owner August 22, 2025 16:02
@bkline bkline requested a review from bryanpizzillo August 22, 2025 16:09
@blairlearn blairlearn force-pushed the ticket/4815-phpstan-issues branch 2 times, most recently from f868416 to fa1dfed Compare September 18, 2025 21:03
@bryanpizzillo
Copy link
Member

@blairlearn what is the status of this?

@blairlearn
Copy link
Contributor

From Teams conversation

Blair
The "phpstan for PDQ" PR -- #4923

The change looks good to me, and I've done some simple testing.
But against the bigger picture of the CDR going away, that's been the extent of it.

(i.e. I've not asked Bob to send edited summaries.)

Bryan
I think we are actually going to merge this during the feature branch work. Basically it should get tested with Summary transforms...

@welshja
Copy link
Collaborator

welshja commented Nov 18, 2025

To test, we'll need to get this onto an ODE and then run the new loader to confirm that things work as expected and all summaries are loaded with no crazy errors/fires/natural disasters. (Orphaned cleanup part of the loading process runs without issue.)

In pdq_cancer_information_summary/src/OrphanCleanup.php:
 - remove line of code inadvertently copied from another method
 - reassure PHP (and phpstan) that we have the the right interface
   for invoking deleteRevision()

Closes #4815
@jfrank-nih jfrank-nih force-pushed the ticket/4815-phpstan-issues branch from fa1dfed to ec192c8 Compare November 19, 2025 16:56
@cgdp-management-server
Copy link

ODE Deployment

Code has been deployed to ODE 1042.

@welshja
Copy link
Collaborator

welshja commented Nov 26, 2025

@jfrank-nih to check with @blairlearn in terms of any testing steps to review on the ODE where it is currently deployed.

@welshja welshja requested review from jfrank-nih and removed request for bryanpizzillo December 11, 2025 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PHPStanCleanup of Deprecated Function and Logic Error Noticed

5 participants