(#5080) Nested External Link Bug #5083
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ODE DeploymentCode has been deployed to ODE 1055. |
| // Temp fix - should be removed once fixed in NCIDS | ||
| // external links in nested DOM | ||
| .usa-prose { | ||
| a:not([class]) { |
Member
There was a problem hiding this comment.
Oh, I thought we were just going to add a rule for the scrollable table wrapper.
karlikpj
force-pushed
the
ticket/5080-nested-ext-links
branch
from
53597ba to
b403de0
Compare
bryanpizzillo
requested changes
Dec 18, 2025
Member
bryanpizzillo
left a comment
bryanpizzillo
left a comment
There was a problem hiding this comment.
Also @karlikpj can you add this to the ncids_full_wysiwyg class, and constrained to usa-prose in that class...?
karlikpj
force-pushed
the
ticket/5080-nested-ext-links
branch
3 times, most recently
from
e9c7b8d to
d09bbfb
Compare
blilianyu
approved these changes
Dec 19, 2025
blilianyu
left a comment
blilianyu
left a comment
There was a problem hiding this comment.
Created an article page and see the external link icon in tables on all breakpoints.
Passes for design. cc: @andyvanavery31 @monika-jaeger
bryanpizzillo
requested changes
Dec 19, 2025
Member
bryanpizzillo
left a comment
bryanpizzillo
left a comment
There was a problem hiding this comment.
Article.scss is still in here.
| @include u-margin-top(1); | ||
| } | ||
| } | ||
| // Temp fix - should be removed once fixed in NCIDS |
Member
There was a problem hiding this comment.
Why is article still being modified since the rule is now in ncids-full-html?
karlikpj
force-pushed
the
ticket/5080-nested-ext-links
branch
2 times, most recently
from
931f93d to
3a55250
Compare
karlikpj
force-pushed
the
ticket/5080-nested-ext-links
branch
from
3a55250 to
f8a7cd1
Compare
andyvanavery31
requested review from
a team
and removed request for
olitharp-nci
andyvanavery31
approved these changes
Dec 19, 2025
alinai
approved these changes
Dec 19, 2025
bryanpizzillo
approved these changes
Dec 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5080
For testing: Please create an Article page with a table that contains external links.