Skip to content

(#5088, #4993) Bump NCIDS to 3.5.0 #5089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
bryanpizzillo wants to merge 1 commit into
base: feature/redesign-r4.2-2
Choose a base branch
from
Open

(#5088, #4993) Bump NCIDS to 3.5.0 #5089

bryanpizzillo wants to merge 1 commit into from

Conversation

@bryanpizzillo
Copy link
Member

@bryanpizzillo bryanpizzillo commented Dec 19, 2025 •
edited by andyvanavery31
Loading

  • Also updated all accordion initialization to supply a heading selector.

Closes #5088
Closes #4993

Test Links

  • /test/test-prose-ext-links
  • /test/test-wysiwyg (either edit the h3 "Table without Classes" to be an h2 or review the draft of this page if someone has already done it)

@bryanpizzillo bryanpizzillo marked this pull request as draft December 19, 2025 22:52
@bryanpizzillo
Copy link
Member Author

bryanpizzillo commented Jan 5, 2026

@KateMashkinaNIH logged an issue. NCIOCPL/ncids#2087 introduced line breaks after external links in prose.

BEFORE:
image

AFTER:
image

This was linked to issues Jan 6, 2026
Update NCIDS to 3.5.0 to fix accordion #5088
Open
When there are multiple section headings to display OTP and user manually adds an H2 heading inside one of the body paragraphs, the mobile accordion becomes nested #4993
Open
@karlikpj karlikpj force-pushed the ticket/5088-update-ncids-3.5.0 branch 3 times, most recently from bd38dc6 to 6f5ab53 Compare January 9, 2026 15:36
@cgdp-management-server
Copy link

cgdp-management-server bot commented Jan 9, 2026

ODE Deployment

Code has been deployed to ODE 1061.

@andyvanavery31 andyvanavery31 requested review from a team and blilianyu January 12, 2026 15:38
blilianyu
blilianyu approved these changes Jan 12, 2026
View reviewed changes
Copy link

@blilianyu blilianyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passes for design
cc: @andyvanavery31

@karlikpj karlikpj force-pushed the ticket/5088-update-ncids-3.5.0 branch 3 times, most recently from c5e3bbf to da2592f Compare January 14, 2026 18:39
@karlikpj karlikpj marked this pull request as ready for review January 14, 2026 18:39
@bryanpizzillo bryanpizzillo force-pushed the ticket/5088-update-ncids-3.5.0 branch from da2592f to 5fb55f8 Compare January 14, 2026 21:53
@bryanpizzillo
(#5088, #4993) Bump NCIDS to 3.5.0
475fa17 
- Also updated all accordion initialization to supply a heading selector, now required.
- Fixes patch for external links in tables to match NCIDS 3.5.0

Closes #5088
Closes #4993
@bryanpizzillo bryanpizzillo force-pushed the ticket/5088-update-ncids-3.5.0 branch from 5fb55f8 to 475fa17 Compare January 16, 2026 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blilianyu blilianyu blilianyu approved these changes

@KateMashkinaNIH KateMashkinaNIH KateMashkinaNIH approved these changes

@andyvanavery31 andyvanavery31 andyvanavery31 approved these changes

@olitharp-nci olitharp-nci Awaiting requested review from olitharp-nci

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

5 participants

@bryanpizzillo @blilianyu @KateMashkinaNIH @andyvanavery31