Skip to content

(#5082) Empty Elements Migration Script #5096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bryanpizzillo merged 1 commit into from
Jan 16, 2026
Merged

(#5082) Empty Elements Migration Script #5096

bryanpizzillo merged 1 commit into from
Jan 16, 2026

Conversation

@dev-rana-publicis
Copy link
Contributor

@dev-rana-publicis dev-rana-publicis commented Jan 7, 2026

Closes #5082

@laurelthrash laurelthrash linked an issue Jan 9, 2026 that may be closed by this pull request
R4.2 Migration: Remove Empty/Unused HTML Elements from Migrated Content #5082
Closed
@dev-rana-publicis dev-rana-publicis force-pushed the ticket/5082-empty-div branch 2 times, most recently from 1b745e3 to 8b59ad8 Compare January 12, 2026 23:11
@bryanpizzillo
Copy link
Member

bryanpizzillo commented Jan 13, 2026 •
edited by laurelthrash
Loading

Next Steps (1/13/2026)

  • Kate to review test output by 11:30
  • Dev run weird things report on migrated content
    - Migrated things should be filtered out (any <div class="cgdp-embed-media-wrapper">
    - don't care about <b>,<strong>,<em>, etc
  • We determine what to do with migration script (Andy, Dev, Adriana, etc)
  • Update code to match decisions
  • Dev reviews (#5100) Fix migration scripts #5101 and it gets merged.

Next Steps (1/14/2026)

@dev-rana-publicis dev-rana-publicis marked this pull request as ready for review January 14, 2026 21:44
@laurelthrash laurelthrash requested review from a team January 15, 2026 18:17
@bryanpizzillo bryanpizzillo merged commit a62273f into feature/redesign-r4.2-2 Jan 16, 2026
5 checks passed
@bryanpizzillo bryanpizzillo deleted the ticket/5082-empty-div branch January 16, 2026 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bryanpizzillo bryanpizzillo bryanpizzillo approved these changes

@KateMashkinaNIH KateMashkinaNIH KateMashkinaNIH approved these changes

@andyvanavery31 andyvanavery31 andyvanavery31 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

R4.2 Migration: Remove Empty/Unused HTML Elements from Migrated Content

5 participants

@dev-rana-publicis @bryanpizzillo @KateMashkinaNIH @andyvanavery31