Skip to content

Conversation

@alerosad
Copy link

@alerosad alerosad commented Aug 25, 2022

Closes #567

  • ErrorPage now scrolls to top on load

… bottom of the page

- ErrorPage now scrolls to top on load
@alerosad alerosad self-assigned this Aug 25, 2022
@alerosad
Copy link
Author

@alinai
Copy link
Contributor

alinai commented Aug 25, 2022

@alerosad , this looks good to me. Noticing that the text in "Have a Question" delighter is wrapping to three lines instead of two lines in Prod. I checked the develop branch and the same issue exits in the develop branch. Just want to make sure that the text wrapping issue will not propagate to Prod.
cc: @sarinapadilla , @KateMashkinaNIH

image
image

@alerosad
Copy link
Author

@alerosad , this looks good to me. Noticing that the text in "Have a Question" delighter is wrapping to three lines instead of two lines in Prod. I checked the develop branch and the same issue exits in the develop branch. Just want to make sure that the text wrapping issue will not propagate to Prod. cc: @sarinapadilla , @KateMashkinaNIH

image image

not sure, seems to be an issue that will need to be addressed in a future ticket

@kate-mashkina
Copy link
Contributor

cts app on dev-ac is pointed to react-app develop branch and the wrapping of the delighter's text is a non-issue. We can safely say that this will not be an issue on upper tiers
@alinai

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hospital/Institution invalid params page loads scrolled to the bottom of the page

5 participants